Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

paginationConfig.maxSize not used #1728

Closed
KenBonny opened this issue Feb 3, 2014 · 9 comments
Closed

paginationConfig.maxSize not used #1728

KenBonny opened this issue Feb 3, 2014 · 9 comments

Comments

@KenBonny
Copy link

KenBonny commented Feb 3, 2014

I set the paginationConfig property maxSize to 5 in the app.config section, but it's not being taken into account on pages.

@bekos
Copy link
Contributor

bekos commented Feb 3, 2014

@KenBonny You are right. Nice catch!
Are you willing to send a PR for this? It's petty straight forward I think.

@KenBonny
Copy link
Author

KenBonny commented Feb 3, 2014

I have no idea what a PR is. But if you give me some directions, then yes, I'll fill it in.

@bekos
Copy link
Contributor

bekos commented Feb 3, 2014

You can search for something like "github how to send pull request" and you will get plenty of useful results.

@KenBonny
Copy link
Author

KenBonny commented Feb 3, 2014

So you fixed the problem?

@bekos
Copy link
Contributor

bekos commented Feb 3, 2014

No. It's still there I believe.

@KenBonny
Copy link
Author

KenBonny commented Feb 3, 2014

Then what will a pull request accomplish?

@bekos
Copy link
Contributor

bekos commented Feb 3, 2014

@KenBonny
Copy link
Author

KenBonny commented Feb 3, 2014

So I should fix the issue and then submit an update? I kinda have to disappoint, I don't have the time to do that right now.

@bekos
Copy link
Contributor

bekos commented Feb 3, 2014

No worries :-)

kaerfredoc added a commit to kaerfredoc/bootstrap that referenced this issue Feb 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants