From 1d58a020eae4fd20ff81f1f78bf4873c716ff7da Mon Sep 17 00:00:00 2001 From: Chris Thielen Date: Wed, 30 Mar 2016 15:50:55 -0500 Subject: [PATCH] docs(Ng1Controller): Fix name of uiOnParamsChanged closes #2653 --- src/ng1/interface.ts | 6 ++++-- src/ng1/viewDirective.ts | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/ng1/interface.ts b/src/ng1/interface.ts index 5569ecd7f..47b940307 100644 --- a/src/ng1/interface.ts +++ b/src/ng1/interface.ts @@ -419,6 +419,8 @@ export interface Ng1ViewDeclaration extends _ViewDeclaration { * */ export interface Ng1Controller { + /** @hidden */ + $onInit(); /** * This callback is called when parameter values have changed. * @@ -439,13 +441,13 @@ export interface Ng1Controller { * ```js * * angular.module('foo').controller('FancyCtrl', function() { - * this.uiOnParamsUpdated = function(newParams) { + * this.uiOnParamsChanged = function(newParams) { * console.log("new params: ", newParams); * } * }); * ``` */ - uiOnParamsUpdated(newValues: any, $transition$: Transition); + uiOnParamsChanged(newValues: any, $transition$: Transition); /** * This callback is called when the view's state is about to be exited. diff --git a/src/ng1/viewDirective.ts b/src/ng1/viewDirective.ts index 88bd2fc8a..c57f6ce2a 100644 --- a/src/ng1/viewDirective.ts +++ b/src/ng1/viewDirective.ts @@ -14,6 +14,7 @@ import {Node} from "../path/node"; import {Param} from "../params/param"; import {kebobString} from "../common/strings"; import {HookRegOptions} from "../transition/interface"; +import {Ng1Controller} from "./interface"; export type UIViewData = { $cfg: Ng1ViewConfig; @@ -381,7 +382,7 @@ function $ViewDirectiveFill ( $compile, $controller, $transitions, $view, } // TODO: move these callbacks to $view and/or `/hooks/components.ts` or something -function registerControllerCallbacks($transitions: TransitionService, controllerInstance, $scope, cfg: Ng1ViewConfig) { +function registerControllerCallbacks($transitions: TransitionService, controllerInstance: Ng1Controller, $scope, cfg: Ng1ViewConfig) { // Call $onInit() ASAP if (isFunction(controllerInstance.$onInit)) controllerInstance.$onInit();