Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Angular 1.3 $animate returns a promise #1345

Closed
wants to merge 1 commit into from
Closed

In Angular 1.3 $animate returns a promise #1345

wants to merge 1 commit into from

Conversation

AVVS
Copy link

@AVVS AVVS commented Sep 9, 2014

No description provided.

@nateabele
Copy link
Contributor

Well, since this patch breaks all other versions of Angular, I guess we'll have to figure something else out...

@AVVS
Copy link
Author

AVVS commented Sep 9, 2014

Yeah, this is obviously just a hotfix for 1.3, to have bc it needs to be slightly more complex. But it still needs to be done

09 ñåíò. 2014 ã., â 14:44, Nate Abele notifications@github.com íàïèñàë(à):

Well, since this patch breaks all other versions of Angular, I guess we'll have to figure something else out...

—
Reply to this email directly or view it on GitHub.

@christopherthielen christopherthielen mentioned this pull request Sep 12, 2014
Closed
@christopherthielen
Copy link
Contributor

additional work needs to be done to support 1.3

#1364

@christopherthielen christopherthielen mentioned this pull request Sep 13, 2014
Closed
christopherthielen added a commit that referenced this pull request Sep 13, 2014
@christopherthielen
fix(uiView): Made anim work with angular 1.3
c3bb7ad 
$animate changed to promise-based in angular 1.3. Added an adapter which
passes the callback to $animate, but if a promise is returned, uses the
promise. Prior PR was #1345

Closes #1367
Closes #1345
@christopherthielen christopherthielen mentioned this pull request Oct 15, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AVVS @nateabele @christopherthielen