Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includedByState with Angular 1.3 #1491

Closed
elitastic opened this issue Oct 30, 2014 · 1 comment
Closed

includedByState with Angular 1.3 #1491

elitastic opened this issue Oct 30, 2014 · 1 comment

Comments

@elitastic
Copy link

Hi

I encountered a problem with Angular 1.3 when using the includedByState directive. My plunker works with Angular 1.2.26, but doesn't with Angular 1.3.

http://plnkr.co/edit/Ip6ou9?p=preview

The problem is that the following statement only fires in 1.2.26, looks like in 1.3 the directive isn't notified about the state change when navigating to substate 'home.foo':

ng-class="{ custom: ('home.foo' | includedByState) }"

Just uncomment one of the two angular version in plunker two see the difference between 1.3 and 1.2.26.

Thank you,
Elias

@christopherthielen
Copy link
Contributor

Elias, can you test against 0.2.12, this should be fixed.

includedByState is a filter not a directive. Also, It's very likely being deprecated. See #1479 for more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants