Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.12 throws an error in IE8 #1556

Closed
thatmarvin opened this issue Nov 17, 2014 · 4 comments
Closed

0.2.12 throws an error in IE8 #1556

thatmarvin opened this issue Nov 17, 2014 · 4 comments
Assignees
Labels
Milestone

Comments

@thatmarvin
Copy link

Save and run this minimal test case in IE8, and see that It throws a TypeError: Object doesn't support this property or method in error in IE8. This works fine in Chrome.

Commit 3d0b121 ("release 0.2.12") is where is started breaking, and the prior commit 896c1e4 ("prep for 0.2.12 release") worked just fine.

@christopherthielen christopherthielen added this to the 0.2.13 milestone Nov 18, 2014
@christopherthielen christopherthielen self-assigned this Nov 18, 2014
@christopherthielen
Copy link
Contributor

IE8 👎

@thatmarvin
Copy link
Author

👎 IE8 indeed. Thanks for the quick fix though! 👍👍

@christopherthielen
Copy link
Contributor

@thatmarvin I'm considering requiring something like es5-shim for ie8 support so I don't have to continually think about writing code non-es5 code. How do you feel about that?

@thatmarvin
Copy link
Author

I include lo-dash in most of my Angular projects so I prefer not to include the shim as well, only just to keep the size down. Maybe provide adapters for both? (Smells a little over-engineered though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants