Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$state.go incorrectly suppressed by reloadOnSearch #1765

Closed
lnpbk opened this issue Feb 19, 2015 · 1 comment
Closed

$state.go incorrectly suppressed by reloadOnSearch #1765

lnpbk opened this issue Feb 19, 2015 · 1 comment

Comments

@lnpbk
Copy link

lnpbk commented Feb 19, 2015

I have a state with url params:

$stateProvider.state('schedule.week', {
    url: '/:year/:week',
    controller: 'ScheduleWeekController',
    templateUrl: 'sections/schedule/week.html',
    reloadOnSearch: false
});

However, when I try to go to the same state with different url params, It's being suppressed. I think by this line: https://github.com/angular-ui/ui-router/blob/master/src/state.js#L993

$state.go($state.current, {
    year: '2015',
    week: '09'
}, {reload: true});

I don't think that reloadOnSearch: false should prevent URL param changes, and should only affect query/search params as the name suggests

@lnpbk lnpbk changed the title state.go falsely suppressed by reloadOnSearch state.go incorrectly suppressed by reloadOnSearch Feb 19, 2015
@lnpbk lnpbk changed the title state.go incorrectly suppressed by reloadOnSearch $state.go incorrectly suppressed by reloadOnSearch Feb 19, 2015
@christopherthielen
Copy link
Contributor

Dupe #1079
Fixed in 0.2.15 commit 6ca0d77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants