Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State based classes leaking between transitioning views #2579

Closed
ns-ctruong opened this issue Feb 24, 2016 · 4 comments
Closed

State based classes leaking between transitioning views #2579

ns-ctruong opened this issue Feb 24, 2016 · 4 comments
Labels
Milestone

Comments

@ns-ctruong
Copy link

After updating to 0.2.18 (from 0.2.15), I noticed some strange behavior in one of our state transition animations. I was using ng-class to apply state specific styles on a child view container.

In 0.2.15, at least, the state specific class was appropriately applied on the entering view only.

In 0.2.18, the view that was transitioning out also received this same class. Here's a plunker. Click on the link for 'Child 1'. You'll see an empty div with a red outline animating out. The red outline should only be applied to the incoming state view for 'Child 1.'

https://plnkr.co/edit/6GhZaOQV0lcO3kLLpjn0?p=preview

@christopherthielen
Copy link
Contributor

I think this is very likely related to the code we added for #1643

I think we will be reverting that code in 0.2.19 in favor of exposing the animation promise: #2562

See also #2485

@christopherthielen christopherthielen added this to the 0.2.19 milestone Feb 24, 2016
@christopherthielen
Copy link
Contributor

I'm leaving this open as a bug ticket, related to the #2562 feature ticket.

@ns-ctruong
Copy link
Author

Great. Thanks for looking into this.

@christopherthielen
Copy link
Contributor

released 0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants