Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @ bindings when using 1.5 components #2708

Closed
drummerboof opened this issue Apr 23, 2016 · 3 comments
Closed

Support @ bindings when using 1.5 components #2708

drummerboof opened this issue Apr 23, 2016 · 3 comments

Comments

@drummerboof
Copy link

Currently, UI Router supports < and = parameters when routing using the component syntax. When the component contains a @ parameter binding, an error is thrown with the message TypeError: Cannot read property '1' of null

Plunkr showing the issue is here: http://embed.plnkr.co/mtNl3MgXrfTkv8NnrtqQ/ The error occurs can be seen in the console.

It seems to be an issue with the handling of the scope bindings in the ng1 viewsBuilder at https://github.com/angular-ui/ui-router/blob/1.0.0-alpha.4/src/ng1/viewsBuilder.ts#L74

@pdanpdan
Copy link
Contributor

On the same topic, optional bindings do not work (<?name, =?name). It tries to create a ?name="::$resolve.?name"

@christopherthielen
Copy link
Contributor

also, bindings that start with UpperCase letters are also broken and translate to -upper-case="::$resolve.UpperCase"

https://plnkr.co/edit/ttcFRmVp9StCTWkHeZbH?p=preview

@christopherthielen
Copy link
Contributor

alpha.5 supports @ bindings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants