This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
make sure sortable classes are removed properly #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebasing, but otherwise LGTM |
|
@wesleycho I have rebased now. Thanks for ploughing through all the PRs, great work! |
|
You've just slightly borked the commit message now 😝 Can you fix? Is there a related issue for this? |
|
Oops No there's no issue - I just came across it and submitted the PR. |
|
@user378230 what are your thoughts - I can merge this locally and alter the message before pushing up if it makes it easier. |
|
@wesleycho LGTM now 👍 feel free to do it locally |
fcaballero
pushed a commit
to fcaballero/ui-select
that referenced
this pull request
Apr 17, 2016
- Correctly remove sortable classes from elements on `dragend` Closes angular-ui#902
fcaballero
pushed a commit
to fcaballero/ui-select
that referenced
this pull request
Apr 25, 2016
- Correctly remove sortable classes from elements on `dragend` Closes angular-ui#902
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.