fix(e2e): return exit codes on failure of e2e tests

[marc-sensenich]

If there is an error, returns the exit code associated with the error in the promise, else returns 0.

Fixes #1017

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[googlebot]

CLAs look good, thanks!

[filipesilva]

Thanks for the contribution! Overall it looks good, but seems to be failing on OSX. I restarted it but it's still failing. Can you have a look?

[marc-sensenich]

I'll look into that issue and try to replicate it locally. I haven't been able to replicate on my MacBook.

[filipesilva]

It seems to fail not on your new tests, but rather on our e2e suite.

That might be because since you fixed the ng e2e error codes, that is uncovering an existing error. It might also be because there is some issue in running it in sequence.

It might be helpful to print stdout and stderr in https://github.com/angular/angular-cli/blob/master/tests/e2e/e2e_workflow.spec.js#L130 to see what's wrong when running on the CI.

[marc-sensenich]

I matched the change you made on .travis.yml and it ran successfully on my Travis instance https://travis-ci.org/marc-sensenich/angular-cli/builds/136321458. It seems to be failing on the projects instance

[filipesilva]

@marc-sensenich the new failures were due to a recent change in master. The old failures where because it turns out that ng e2e never worked on travis OSX, because of the chrome versions. I merged your code in, but moved the acceptance test into the e2e workflow.

I did this because I ran into a situation where the acceptance test was accepting failures in the ng e2e command while debugging. This has happened before and it's the reason why most tests that deal with the generated project are ran in e2e_workflow.spec.js.

Thanks for picking this issue up by the way, it was leading to some hard to detect silent fails!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}