Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): add icons/ path in front of icon src values #1181

Closed
wants to merge 1 commit into from

Conversation

Splaktar
Copy link
Member

fix 'Add to Homescreen' on mobile not finding icons in dist/icons
seen when running ng build --prod

Fixes #1179

@filipesilva
Copy link
Contributor

Closed as this PR was made obsolete by #1455.

@Splaktar
Copy link
Member Author

@filipesilva I'm just curious how this was obsoleted (I haven't had time to re-read the full angular-cli source since the #1455 was merged). Is --mobile still supported? Are blueprints still supported? Is there still a manifest.webapp blueprint?

@filipesilva
Copy link
Contributor

@Splaktar --mobile is still supported, and index was updated directly:

https://github.com/angular/angular-cli/blob/master/addon/ng2/blueprints/ng2/files/__path__/index.html

But now that I look, the manifest wasn't!

https://github.com/angular/angular-cli/blob/master/addon/ng2/blueprints/ng2/files/__path__/index.html

Reopening your PR, can you rebase?

@filipesilva filipesilva reopened this Jul 27, 2016
@Splaktar
Copy link
Member Author

Splaktar commented Jul 27, 2016

OK, thank you for the info. I'll rebase and update for the new changes as soon as I have time.

I'm guessing that your second link was supposed to point to here?
https://github.com/angular/angular-cli/blob/master/addon/ng2/blueprints/mobile/files/__path__/manifest.webapp

@filipesilva
Copy link
Contributor

Yes, correct!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

fix 'Add to Homescreen' on mobile not finding icons

Fixes angular#1179
@Splaktar Splaktar force-pushed the fixManifestIconPath branch from 3e623f5 to 5fd5476 Compare July 31, 2016 19:33
@googlebot
Copy link

CLAs look good, thanks!

@Splaktar
Copy link
Member Author

@filipesilva rebase complete. Ready to go.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webapp Manifest icons are generated with invalid paths
3 participants