-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mobile): add icons/
path in front of icon src
values
#1181
Conversation
Closed as this PR was made obsolete by #1455. |
@filipesilva I'm just curious how this was obsoleted (I haven't had time to re-read the full angular-cli source since the #1455 was merged). Is |
@Splaktar But now that I look, the manifest wasn't! Reopening your PR, can you rebase? |
OK, thank you for the info. I'll rebase and update for the new changes as soon as I have time. I'm guessing that your second link was supposed to point to here? |
Yes, correct! |
9e9c323
to
3e623f5
Compare
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
fix 'Add to Homescreen' on mobile not finding icons Fixes angular#1179
3e623f5
to
5fd5476
Compare
CLAs look good, thanks! |
@filipesilva rebase complete. Ready to go. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fix 'Add to Homescreen' on mobile not finding icons in
dist/icons
seen when running
ng build --prod
Fixes #1179