Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): update to npm 3.10.2 #1250

Merged
merged 1 commit into from
Jun 30, 2016
Merged

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Jun 30, 2016

The npm task from our current ember-cli install uses npm 2.x.x, which was causing issues with some of the dependencies.

This PR copies over all files needed for the npm-install task but uses a local 3.10.2 npm version instead.

Fix #1186 (main issue)
Fix #1191
Fix #1201
Fix #1209
Fix #1207
Fix #1248

The npm task from our current ember-cli install uses npm 2.x.x, which was causing issues with some of the dependencies.

This PR copies over all files needed for the npm-install task but uses a local 3.10.2 npm version instead.

Fix angular#1186 (main issue)
Fix angular#1191
Fix angular#1201
Fix angular#1209
Fix angular#1207
Fix angular#1248
@cironunes
Copy link
Member

LGTM

@filipesilva filipesilva merged commit 6f0ebfb into angular:master Jun 30, 2016
@Splaktar
Copy link
Member

Thank you!

@choucry13
Copy link

+1 👍

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants