Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Use ExtractTextPlugin for global styles #2148

Closed
jimitndiaye opened this issue Sep 15, 2016 · 3 comments
Closed

Proposal: Use ExtractTextPlugin for global styles #2148

jimitndiaye opened this issue Sep 15, 2016 · 3 comments
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@jimitndiaye
Copy link
Contributor

jimitndiaye commented Sep 15, 2016 •
edited
Loading

Please provide us with the following information:

  1. OS? Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
    Windows 10

  2. Versions. Please run ng --version. If there's nothing outputted, please run
    in a Terminal: node --version and paste the result here:
    1.0.0-beta.14

  3. Repro steps. Was this an app that wasn't created using the CLI? What change did you
    do on your code? etc.
    Create a new app using ng new my-app.
    Run ng serve
    styles.css is loaded using style-loader causing flash during initial load

  4. The log given by the failure. Normally this include a stack trace and some
    more information.
    n/a

  5. Mention any other details that might be useful.
    Especially for production builds you'd get better UX by loading the styles as a static resource rather than waiting for JS to load and run. Even in dev builds live-reload still works with static files using ExtractTextPlugin

    Thanks! We'll be in touch soon.
@filipesilva
Copy link
Contributor

Would you be willing to make a PR for this?

/cc @TheLarkInn

@filipesilva filipesilva added type: enhancement P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels Sep 21, 2016
jimitndiaye pushed a commit to jimitndiaye/angular-cli that referenced this issue Oct 11, 2016
fix(angular#2148): Use static files for styles
99d655f 
Uses extract-loader to prepare static files for styles rather than use style-loader and thus avoids FOUC.
jimitndiaye added a commit to jimitndiaye/angular-cli that referenced this issue Oct 11, 2016
@jimitndiaye
fix(build): Use static files for styles.
ebe2e35 
Close angular#2148
@jimitndiaye
Copy link
Contributor Author

@filipesilva submitted PR #2646

@jimitndiaye jimitndiaye mentioned this issue Oct 14, 2016
Closed
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@jimitndiaye @MRHarrison
feat(build): use static files for css
99fdd33 
Fix angular#2148
Fix angular#2020
Fix angular#2826
Close angular#2646
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): Use static files for styles jimitndiaye/angular-cli
2 participants
@jimitndiaye @filipesilva