Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): correctly report appveyor failures #2238

Merged
merged 2 commits into from
Sep 27, 2016
Merged

fix(ci): correctly report appveyor failures #2238

merged 2 commits into from
Sep 27, 2016

Conversation

filipesilva
Copy link
Contributor

No description provided.

@filipesilva filipesilva force-pushed the fix-appveyor-script branch 4 times, most recently from ae77dfb to 43e3f57 Compare September 20, 2016 04:46
TheLarkInn
TheLarkInn approved these changes Sep 20, 2016
View reviewed changes
Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. unless @hansl spots something himself.

@filipesilva
Copy link
Contributor Author

There's something wrong still, at least on windows. The CI should fail, and it isn't failing.

@filipesilva
Copy link
Contributor Author

filipesilva commented Sep 20, 2016 •
edited
Loading

It's not a windows problem apparently, npm test has failures on linux as well but the CI passes:
travis - https://travis-ci.org/angular/angular-cli/jobs/161231177#L2049
appveyour - https://ci.appveyor.com/project/AngularCLI/angular-cli/build/1.0.2861/job/nowqpp3boup5o4a1#L1828

@filipesilva filipesilva force-pushed the fix-appveyor-script branch 2 times, most recently from 868b98b to 8f4c898 Compare September 27, 2016 12:28
@filipesilva
Copy link
Contributor Author

Turns out that you must manually set the exit code when not using the default reporter.

@filipesilva filipesilva merged commit 3102453 into angular:master Sep 27, 2016
@filipesilva filipesilva deleted the fix-appveyor-script branch September 27, 2016 18:39
JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 2, 2016
@filipesilva
fix(test): correctly report packages spec failures (angular#2238)
3aff7ad
deebloo pushed a commit to deebloo/angular-cli that referenced this pull request Oct 3, 2016
@filipesilva
fix(test): correctly report packages spec failures (angular#2238)
c395f2d
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TheLarkInn TheLarkInn TheLarkInn approved these changes

@Brocco Brocco Brocco approved these changes

@hansl hansl hansl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@filipesilva @hansl @Brocco @TheLarkInn @googlebot