Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the tree shaking #6233

Closed
ghost opened this issue May 9, 2017 · 4 comments
Closed

Issue with the tree shaking #6233

ghost opened this issue May 9, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented May 9, 2017

Bug Report or Feature Request (mark with an x)

- [ x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

1.0.2

Repro steps.

I create a simple projet with angular/cli
I added two libs:
"@angular/animations": "^4.0.0" "primeng": "4.0.0"
In app.module.ts, I had:
import { SharedModule as PrimeNgSharedModule } from 'primeng/primeng';
When I import PrimeNgSharedModule in @NgModule.imports, my bundle grows from 2.29mb to 3.19mb ! (this module is very small...)

Whatever module, I had, the size will be always the same, all the content of primeng/primeng is added, there is not tree shaking here....

@filipesilva
Copy link
Contributor

Mostly dupe of #2901.

The amount of tree shaking that happens depends on how primeng is setup as well. Webpack supports limited tree shaking (depends on your definition), not as much as rollup. We currently used Webpack and are thus limited by their support.

@debuggerpk
Copy link

hi @filipesilva, mind if i ask, does angular team has any plans of moving to rollup?

@filipesilva
Copy link
Contributor

No, that is not part of our plans currently. It would require a massive rework of the build system.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants