fix(): skips initialization of git if directory is already under version control #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +30,23 @@ module.exports = Task.extend({ | |||
|
|
|||
| return exec('git --version') | |||
| .then(function () { | |||
|
|
|||
| // "true" if cmd executes in a work tree | |||
There was a problem hiding this comment.
These 3 comments are more confusing than helping. I suggest adding a single comment for the git command such as Check if we're inside a git repo.
|
Many thanks for the feedback! |
|
Looks good. I'll submit it when I have time to rebase or if you want to rebase quickly I'll merge. Thanks! |
avoids a nested git repo, which is probably not what we wanted to have
|
Done. Squashed and rebased! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids nested git repos, which are probably not what we wanted to have
see also: http://boxysystems.com/index.php/nested-git-repo-gotchas/