fix(isArrayLike) Correctly detect arrayLike items

[dcherman]

Change the implementation of isArrayLike to use one heavily based on the
implementation in jQuery in order to correctly detect array-like
objects, that way functionality like ngRepeat works as expected.

[dcherman]

Just taking over where #2878 left off since that PR hasn't been addressed in a bit

[petebacondarwin]

PR Checklist (Minor Bugfix)

• Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name)
• PR doesn't introduce new api
• PR doesn't contain a breaking change
• PR contains unit tests
• PR contains e2e tests (if suitable)
• PR contains documentation update (if suitable)
• PR passes all tests on Travis (sanity)
• PR passes all tests on ci.angularjs.org (cross-browser compatibility)
• PR is rebased against recent master
• PR is squashed into one commit per logical change
• PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
• All changes requested in review have been implemented

[petebacondarwin]

@dcherman - thanks for this PR. I have closed #2878 in favour of this. Can you please ensure that you have signed the CLA?

[dcherman]

@petebacondarwin Just need to check with my employer to make sure it's all good. I'll sign it as soon as I have that approval.

[dcherman]

@petebacondarwin Signed

[petebacondarwin]

Great

Pete
...from my mobile.
On 29 Jul 2013 22:42, "dherman" notifications@github.com wrote:

@petebacondarwin https://github.com/petebacondarwin Signed

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3356#issuecomment-21754031
.

[ksheedlo]

Looks good. I'm going to merge this.

[ksheedlo]

landed in fad626f

[thorn0]

Please fix this.
See example: http://plnkr.co/edit/oPlqnqxBjxEbvE3GQflq?p=preview
It worked with Angular 1.1.0: http://plnkr.co/edit/cxnaNC?p=preview

[its-your-favorite]

Well done guys, gave up on it in the one-month gap when I didn't hear anything and I guess I wasn't subscribed, I'm glad you've taken it on yourselves to get it through.