not parsing expressions in attributes, select with ng-options Angular 1.2.0.rc3

[ygorcardoso]

Hi guys,

I had a few dropdows that were working fine in my project until rc2, but rc3 broke them.

Some dynamic attributes I have are not being parsed at all, like for example, id="something{{$index}}; the same attributes in other input types or dropdowns without ng-options are parsed just fine.

Here's a fiddle exemplifying the problem: http://jsfiddle.net/S6vz7/1/, you can notice the difference when you hover selects or inputs.

Regards,
Ygor

[heikki]

I noticed the same thing with select & id attribute.

[ygorcardoso]

It seems to be related to 31f190d, but not sure what's the best way to get around it.

[astik]

Here are some results of what I have found :

Suppose that "directive" is our own directive which access attribute that needs to be interpolated.
Its priority is default (0).

Here is a sample HTML :

<select
    data-ng-model="woot"
    data-ng-options="str as str for str in awesomeThings"
    data-directive1
    data-my-param="{{testObject.param1}}"
></select>

We have 4 declared directives : select, ngModel, ngOptions, directive1.
Angular add an implicit directive : interpolation directive.

Directives are loaded from highest priority to lower.

In RC2 :

function applyDirectivesToNode(directives, compileNode, templateAttrs, transcludeFn, jqCollection, originalReplaceDirective) {

directives contains those 5 objects :

0   Object { priority=100, compile=function()}                     - interpolation directive
1   Object { restrict="E", require=[2], controller=[4], more...}   - select directive
2   Object { restrict="A", priority=0, name="directive1", more...} - directive1 directive
3   Object { terminal=true, priority=0, name="ngOptions", more...} - ngOptions directive
4   Object { require=[2], controller=[6], priority=0, more...}     - ngModel directive

In RC3 :

function applyDirectivesToNode(directives, compileNode, templateAttrs, transcludeFn, jqCollection, originalReplaceDirective, preLinkFns, postLinkFns, previousCompileContext) {

directives contains those 5 objects :

0   Object { restrict="A", priority=0, index=0, more...}         - directive1 directive
1   Object { require=[2], controller=[6], priority=0, more...}   - ngModel directive
2   Object { terminal=true, priority=0, index=0, more...}        - ngOptions        terminal:true
3   Object { restrict="E", require=[2], controller=[4], more...} - select directive
4   Object { priority=-100, compile=function()}                  - interpolation directive

The interpolation directive has its priority changed from 100 (in RC2) to -100 (in RC3).
It used to be first in line, now it is last.

The terminal property does not mean that the directive is the final one, it means that its priority will be the lowest possible one for the current element.

if (terminalPriority > directive.priority) {
    break; // prevent further processing of directives
}

As the ngOptions directive is terminal, the lowest priority possible is set to 0.
The "interpolation directive" has a priority of -100 and is not loaded.
So that, attrInterpolateLinkFn is not available into postLinkFns and is not triggered.

[jamie-pate]

so.. select directive priority should be -101.. :)

[rodyhaddad]

Test your jsfiddle (it's already using the latest snapshot). It works now :)

Gotta thank 79223ea

[ygorcardoso]

Yeah, noticed it too, nice to see the problem is not forgotten :)

[ygorcardoso]

Closed the issue as it's working in 1.2 release.