Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete type list in commit guidelines: add "release" type #20537

Closed
marionebl opened this issue Nov 20, 2017 · 5 comments
Closed

Incomplete type list in commit guidelines: add "release" type #20537

marionebl opened this issue Nov 20, 2017 · 5 comments
Labels
feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature freq3: high P4 A relatively minor issue that is not relevant to core functions state: needs eng input
Milestone

Comments

@marionebl
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

The list of allowed commit types at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#type currently list no type appropriate for project activities like releasing, for which previously the chore type was used.

The Angular project itself uses a release type, e.g. here: https://github.com/angular/angular/commits/master/package.json

Expected behavior

The commit conventions list all types in use. Add "release" to list of allowed types

What is the motivation / use case for changing the behavior?

Create a reliable single source of truth for commit conventions external tools such as

@jenniferfell
Copy link
Contributor

docsarea=contributing

@jelbourn jelbourn added P4 A relatively minor issue that is not relevant to core functions and removed severity2: inconvenient labels Oct 1, 2020
@angular-robot angular-robot bot added the feature: votes required Feature request which is currently still in the voting phase label Jun 4, 2021
@angular-robot
Copy link
Contributor

angular-robot bot commented Jun 4, 2021

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link
Contributor

angular-robot bot commented Jun 26, 2021

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added the feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors label Jun 26, 2021
@mgechev
Copy link
Member

mgechev commented Mar 21, 2022

Since the release commit type is meant for only Angular caretakers, I'll close the issue as "wont fix" for now. If you disagree, please open a new issue and share details why you think it should be part of the docs.

@mgechev mgechev closed this as completed Mar 21, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature freq3: high P4 A relatively minor issue that is not relevant to core functions state: needs eng input
Projects
None yet
Development

No branches or pull requests

5 participants