-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to RC7 #505
Upgrade to RC7 #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you enjoy my inline comments. Generally looks good, just nits.
@@ -37,6 +37,8 @@ | |||
"@angular/core": "^2.0.0-rc.5", | |||
"@angular/platform-browser": "^2.0.0-rc.5", | |||
"@angular/platform-browser-dynamic": "^2.0.0-rc.5", | |||
"@types/bluebird": "^3.0.32", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why bluebird types? We're not using bluebird library
firebase: 'node_modules/firebase/firebase.js', | ||
'app': 'dist' | ||
'app': 'dist', | ||
'@angular/core': 'npm:@angular/core/bundles/core.umd.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can SystemJS load the ES modules instead, using the old configuration but adding format: 'esm'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind
{pattern: 'karma-test-shim.js', included: true, watched: true}, | ||
{pattern: 'built/test/matchers.js', included: true, watched: true}, | ||
{ pattern: 'karma-test-shim.js', included: true, watched: true }, | ||
//{ pattern: 'dist/test/matchers.js', included: true, watched: true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the line
@@ -37,6 +37,8 @@ | |||
"@angular/core": "^2.0.0-rc.5", | |||
"@angular/platform-browser": "^2.0.0-rc.5", | |||
"@angular/platform-browser-dynamic": "^2.0.0-rc.5", | |||
"@types/bluebird": "^3.0.32", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need these types if we're not using Bluebird?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be gone. Needed it for debugging.
export const ANON_AUTH_CONFIG = { | ||
method: AuthMethods.Anonymous, | ||
provider: AuthProviders.Anonymous | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NEWLINE!!!!
Addresses #468 #493 #499 #502
And hopefully some auth issues too #496