Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to RC7 #505

Merged
merged 7 commits into from
Sep 15, 2016
Merged

Upgrade to RC7 #505

merged 7 commits into from
Sep 15, 2016

Conversation

davideast
Copy link
Member

Addresses #468 #493 #499 #502

And hopefully some auth issues too #496

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@jeffbcross jeffbcross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you enjoy my inline comments. Generally looks good, just nits.

@@ -37,6 +37,8 @@
"@angular/core": "^2.0.0-rc.5",
"@angular/platform-browser": "^2.0.0-rc.5",
"@angular/platform-browser-dynamic": "^2.0.0-rc.5",
"@types/bluebird": "^3.0.32",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bluebird types? We're not using bluebird library

firebase: 'node_modules/firebase/firebase.js',
'app': 'dist'
'app': 'dist',
'@angular/core': 'npm:@angular/core/bundles/core.umd.js',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can SystemJS load the ES modules instead, using the old configuration but adding format: 'esm'?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind

{pattern: 'karma-test-shim.js', included: true, watched: true},
{pattern: 'built/test/matchers.js', included: true, watched: true},
{ pattern: 'karma-test-shim.js', included: true, watched: true },
//{ pattern: 'dist/test/matchers.js', included: true, watched: true },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the line

@@ -37,6 +37,8 @@
"@angular/core": "^2.0.0-rc.5",
"@angular/platform-browser": "^2.0.0-rc.5",
"@angular/platform-browser-dynamic": "^2.0.0-rc.5",
"@types/bluebird": "^3.0.32",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these types if we're not using Bluebird?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be gone. Needed it for debugging.

export const ANON_AUTH_CONFIG = {
method: AuthMethods.Anonymous,
provider: AuthProviders.Anonymous
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWLINE!!!!

@jeffbcross jeffbcross merged commit 2410b2d into angular:master Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants