Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update installation guide to latest cli version #519

Merged
merged 2 commits into from
Sep 20, 2016
Merged

update installation guide to latest cli version #519

merged 2 commits into from
Sep 20, 2016

Conversation

cre8
Copy link

@cre8 cre8 commented Sep 17, 2016

The latest cli build (14) is based on webpack in the master branch so you don't need the @webpack anymore.

The latest cli build (14) is based on webpack in the master branch so you don't need the `@webpack` anymore.
Before you start installing AngularFire2, make sure you have correct version of angular-cli installed.
To verify run the command `ng -v` and ensure you see `angular-cli: 1.x.x-beta.x-webpack.x`.
Before you start installing AngularFire2, make sure you have latest version of angular-cli installed.
To verify run the command `ng -v` and ensure you see `angular-cli: 1.x.x-beta.14`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of .14, can we use .xx here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's useful to mention that .14 is the minimum.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point!

@davideast
Copy link
Member

One comment, but otherwise this is great :)

Added lowest possible version of angular-cli
Copy link
Author

@cre8 cre8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimum version added

@davideast davideast merged commit 648666f into angular:master Sep 20, 2016
@cre8 cre8 deleted the patch-1 branch September 22, 2016 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants