Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-raised-button on anchor always have disabled styles #1946

Closed
fxck opened this issue Nov 21, 2016 · 7 comments
Closed

md-raised-button on anchor always have disabled styles #1946

fxck opened this issue Nov 21, 2016 · 7 comments

Comments

@fxck
Copy link
Contributor

fxck commented Nov 21, 2016

it appears to have disabled="false", which matches these rules

[md-raised-button].md-primary[disabled], [md-raised-button].md-accent[disabled], [md-raised-button].md-warn[disabled], [md-raised-button][disabled][disabled], [md-fab].md-primary[disabled], [md-fab].md-accent[disabled], [md-fab].md-warn[disabled], [md-fab][disabled][disabled], [md-mini-fab].md-primary[disabled], [md-mini-fab].md-accent[disabled], [md-mini-fab].md-warn[disabled], [md-mini-fab][disabled][disabled]

it shouldn't have disabled attribute at all(should be undefined instead of false).

would make plunker, but it appears to be outdated( @devversion )

image

@fxck
Copy link
Contributor Author

fxck commented Nov 21, 2016

apparently was fixed in 716372b#diff-a9be5af2302f13e68145b436ee01073aR145

?

@jelbourn
Copy link
Member

Should be fixed already in master, will be released in alpha.11

@fxck
Copy link
Contributor Author

fxck commented Nov 30, 2016

https://github.com/angular/material2/milestone/12 is this accurate?

@jelbourn
Copy link
Member

@fxck nope, I've been terrible about keeping the milestones up to date.

@fxck
Copy link
Contributor Author

fxck commented Nov 30, 2016

You don't say. 😄 OK, are there any big features blocking it, or just some polishing to do?

@jelbourn
Copy link
Member

@fxck #1915, #1907, #2026, #2014, and a fix for #1973

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants