Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/table): unsubscribe from source when disconnecting #21338

Merged
merged 1 commit into from
Dec 17, 2020
Merged

fix(material/table): unsubscribe from source when disconnecting #21338

merged 1 commit into from
Dec 17, 2020

Conversation

crisbeto
Copy link
Member

  • Fixes that the table data source wasn't unsubscribing from sorting, pagination etc. when it is disconnected.
  • Adds a bit of logic to properly support re-connecting the same date source again.
  • Fixes up a couple of issues in the unit test setup which could cause state to leak between tests.

Fixes #21270.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 13, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2020
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Dec 15, 2020
@crisbeto
fix(material/table): unsubscribe from source when disconnecting
5b9f60a 
* Fixes that the table data source wasn't unsubscribing from sorting, pagination etc. when it is disconnected.
* Adds a bit of logic to properly support re-connecting the same date source again.
* Fixes up a couple of issues in the unit test setup which could cause state to leak between tests.

Fixes angular#21270.
@crisbeto crisbeto force-pushed the 21270/data-source-unsubscribe branch from 168b4fd to 5b9f60a Compare December 16, 2020 18:37
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Dec 17, 2020
@mmalerba mmalerba merged commit 6d36942 into angular:master Dec 17, 2020
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@crisbeto @wagnermaciel
fix(material/table): unsubscribe from source when disconnecting (angu…
c2eeaf0 
…lar#21338)

* Fixes that the table data source wasn't unsubscribing from sorting, pagination etc. when it is disconnected.
* Adds a bit of logic to properly support re-connecting the same date source again.
* Fixes up a couple of issues in the unit test setup which could cause state to leak between tests.

Fixes angular#21270.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatTableDataSource does not unsubscribe from sort and paginator streams
3 participants
@crisbeto @andrewseguin @mmalerba