Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript miscompilation error when trying to run "demo-app" task #2134

Closed
shootermv opened this issue Dec 9, 2016 · 3 comments
Closed

Comments

@shootermv
Copy link

shootermv commented Dec 9, 2016

Bug:

expected - the demo app to run

current behavior -
geting error:
Unable to compile TypeScript
tools/gulp/tasks/release.ts (52,10): Type 'Promise<{}>' is not assignable to type 'Promise'

steps to reproduce:
open terminal in root directory of project and run "npm run demo-app"

proposition for fix:
replace following line (tools/gulp/tasks/release.ts (52,10)):
"function _execNpmPublish(label: string): Promise< void > {"
with:
"function _execNpmPublish(label: string): Promise<{}> {"

I'm newbie, so i guess there may be some more elegant solutions...

@crisbeto
Copy link
Member

crisbeto commented Dec 9, 2016

#2132 should fix it.

@crisbeto crisbeto added the has pr label Dec 9, 2016
@crisbeto
Copy link
Member

Closing since #2132 was merged.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants