-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material-experimental/mdc-select): arrow not rendering in high contrast mode #21606
Merged
annieyw
merged 1 commit into
angular:master
from
crisbeto:mdc-select-high-contrast-arrow
Mar 7, 2021
Merged
fix(material-experimental/mdc-select): arrow not rendering in high contrast mode #21606
annieyw
merged 1 commit into
angular:master
from
crisbeto:mdc-select-high-contrast-arrow
Mar 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntrast mode The MDC select uses a CSS triangle for its down arrow which renders as a rectangle in high contrast mode. These changes switch it to an SVG arrow. These changes are identical to angular#14219 which had some trouble landing due to screenshot diffs. The MDC select shouldn't have such issues. Relates to angular#21263.
crisbeto
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
labels
Jan 15, 2021
google-cla
bot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Jan 15, 2021
mmalerba
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
annieyw
pushed a commit
that referenced
this pull request
Mar 7, 2021
…ntrast mode (#21606) The MDC select uses a CSS triangle for its down arrow which renders as a rectangle in high contrast mode. These changes switch it to an SVG arrow. These changes are identical to #14219 which had some trouble landing due to screenshot diffs. The MDC select shouldn't have such issues. Relates to #21263. (cherry picked from commit fef9179)
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Accessibility
This issue is related to accessibility (a11y)
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MDC select uses a CSS triangle for its down arrow which renders as a rectangle in high contrast mode. These changes switch it to an SVG arrow.
These changes are identical to #14219 which had some trouble landing due to screenshot diffs. The MDC select shouldn't have such issues.
Relates to #21263.