-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/schematics): generate code that works in strict CLI projects #22052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Feb 28, 2021
Splaktar
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
area: ng-generate
Schematics that generate code in user projects
labels
Feb 28, 2021
Splaktar
force-pushed
the
schematic-strictness
branch
from
February 28, 2021 02:00
80ad786
to
71e2a6d
Compare
crisbeto
approved these changes
Feb 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...te/table/files/__path__/__name@dasherize@if-flat__/__name@dasherize__-datasource.ts.template
Outdated
Show resolved
Hide resolved
…ects - fix `strictNullChecks` errors - fix `strictPropertyInitialization` errors - default to smaller paginator rows so that paging works out of the box - fix tslint errors from default CLI settings Fixes angular#21981
- fix tslint error from default CLI settings Relates to angular#21981
Splaktar
force-pushed
the
schematic-strictness
branch
from
March 1, 2021 18:29
71e2a6d
to
43ec7e6
Compare
annieyw
pushed a commit
that referenced
this pull request
Mar 5, 2021
…ects (#22052) * fix(material/schematics): generate code that works in strict CLI projects - fix `strictNullChecks` errors - fix `strictPropertyInitialization` errors - default to smaller paginator rows so that paging works out of the box - fix tslint errors from default CLI settings Fixes #21981 * fix(cdk/schematics): generate code that works in strict CLI projects - fix tslint error from default CLI settings Relates to #21981 (cherry picked from commit 0441ae9)
This was referenced Mar 11, 2021
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: ng-generate
Schematics that generate code in user projects
cla: yes
PR author has agreed to Google's Contributor License Agreement
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strictNullChecks
errorsstrictPropertyInitialization
errorsFixes #21981