Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages don't contain scss files #533

Closed
VFedyk opened this issue May 26, 2016 · 13 comments
Closed

Packages don't contain scss files #533

VFedyk opened this issue May 26, 2016 · 13 comments

Comments

@VFedyk
Copy link

VFedyk commented May 26, 2016

I have installed 2.0.0-alpha-5 and there is no SCSS files. What was the reason of doing that?

@kreed-rmn
Copy link

I found the reason for this was node-sass hadn't been recompiled.

npm rebuild node-sass fixed it for me.

@VFedyk
Copy link
Author

VFedyk commented May 26, 2016

It is how package looks for me now:
list-2 0 0-alpha 5 tgz _126

And it is not only in list package.

@VFedyk
Copy link
Author

VFedyk commented May 26, 2016

The same list package but earlier version:
list-2 0 0-alpha 4 1 tgz _127

@Delagen
Copy link

Delagen commented May 26, 2016

I am waiting for theming solution. Current implementation so ugly, in state of npm is even impossible. Sad that no any issue with plan for distribution with theme support and bundling into single css file in case that shadow css isn.t the best solution in some cases

@aminebizid
Copy link

I added an issue but Mister @jelbourn closed it without any explanation.

@jelbourn
Copy link
Member

jelbourn commented May 26, 2016

The missing scss files wasn't intentional; it was likely due to changes in the angular-cli. We'll look into the problem.

As far as a real theming API: it will come eventually, but in the short term we're focused on having components to theme 😃. Generally, issues asking "When will X be done?" will just be closed.

@aminebizid
Copy link

I just asked to add a milestone for theming. To know if we workaround it or wait for it.

@VFedyk
Copy link
Author

VFedyk commented May 26, 2016

@jelbourn, maybe it wasn't intentional but they were in for at least two last versions and we have built project which relies on these files. And then, suddenly, they disappeared. Is it possible to rebuild recent packages?

@jelbourn
Copy link
Member

jelbourn commented Jun 1, 2016

Just published an alpha.5-2 which contains the scss source.

@jelbourn jelbourn closed this as completed Jun 1, 2016
@TheCaptainDate
Copy link

TheCaptainDate commented Jun 3, 2016

@jelbourn
Still broken.
There is css and scss files now with same name, so @import inside material2 scss files don't know which file should be imported, and returns an error.
I think this can be fixed if you put extensions in material2 scss files, or remove all css files from package.

@Delagen
Copy link

Delagen commented Jun 3, 2016

While no any distribution policy It is fun. Because all styles are embedded in source ((

@ddjonline
Copy link

What is the recommended way to handle the scss and css in the same directories with the node-sass option (I know the angular-cli "just works" but that isn't an option for some)?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants