Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): remove use of Angular private API #195

Merged
merged 1 commit into from
Feb 22, 2017
Merged

Conversation

ThomasBurleson
Copy link
Contributor

@ThomasBurleson ThomasBurleson commented Feb 22, 2017

flex-layout uses private APIs from @angular/core. These apis are no longer available in A4.

Fixes #193.

@ThomasBurleson ThomasBurleson changed the title fix(fxHide, fxShow): allow fxHide+fxShow usages on same element fix(build): remove use of Angular private API Feb 22, 2017
@ThomasBurleson ThomasBurleson self-assigned this Feb 22, 2017
@ThomasBurleson ThomasBurleson added this to the v2.0.0-rc.1 milestone Feb 22, 2017
@ThomasBurleson
Copy link
Contributor Author

ThomasBurleson commented Feb 22, 2017

@IgorMinar - FYI.

**flex-layout** uses private APIs from @angular/core. These apis are no longer available in A4.

NOTE: `custom-matchers.ts` still uses the private API for Angular 2.x unit testing. Further work is need to identify a reasonable work-around for all versions of Angular.

Fixes #193.
@mmalerba mmalerba merged commit d95cb09 into master Feb 22, 2017
@ThomasBurleson ThomasBurleson deleted the fix/issue_193 branch March 4, 2017 22:54
karlhaas pushed a commit to karlhaas/flex-layout that referenced this pull request May 3, 2017
**flex-layout** uses private APIs from @angular/core. These apis are no longer available in A4.

NOTE: `custom-matchers.ts` still uses the private API for Angular 2.x unit testing. Further work is need to identify a reasonable work-around for all versions of Angular.

Fixes angular#193.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove private Angular API usage
3 participants