fix(fxLayoutAlign): support flex-start and flex-end options #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmalerba - please review ? |
mmalerba
approved these changes
Mar 28, 2017
src/lib/flexbox/api/layout-align.ts
Outdated
| } | ||
|
|
||
| css['align-items'] = 'stretch'; // default cross axis |
There was a problem hiding this comment.
nit: why not just put these in the default block? (same above)
Current API translates `start` and `end` to `flex-start` and `flex-end` respectively. The API should also support the raw flex-<xxx> values. Fixes #232.
ThomasBurleson
force-pushed
the
thomas/fix-issue-232
branch
from
4076cf4
to
1913570
Compare
karlhaas
pushed a commit
to karlhaas/flex-layout
that referenced
this pull request
May 3, 2017
) Current API translates `start` and `end` to `flex-start` and `flex-end` respectively. The API should also support the raw flex-<xxx> values. Fixes angular#232.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current API translates
startandendtoflex-startandflex-endrespectively.The API should also support the raw
flex-<xxx>values.Fixes #232.