Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rxjs import #99

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Fix rxjs import #99

merged 1 commit into from
Jan 6, 2017

Conversation

bowenni
Copy link
Contributor

@bowenni bowenni commented Jan 6, 2017

No description provided.

@jelbourn
Copy link
Member

jelbourn commented Jan 6, 2017

LGTM

FYI @ThomasBurleson, importing from 'rxjs' alone brings in the entire library with all operators vs. justing bringing in the parts you're using. We have a check in the material2 CI that blocks doing this.

@jelbourn jelbourn merged commit 88d1b0f into angular:master Jan 6, 2017
@bowenni bowenni deleted the demo-rxjs branch January 6, 2017 19:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bowenni @jelbourn @googlebot