-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Rename Material services to have $material
prefixes
#314
Comments
As I recall, the intention was to identify Angular Material services with conformance to the naming conventions in Angular. Since currently we only publish |
Could we not just make a utility function for expectAria? |
Every service should be prefixed with |
I think a decorator is the wrong approach. I'm going to go with @ajoslin's suggestion for now. |
No problem with |
@btford Is the |
That's actually a great idea @ThomasBurleson. It's a great way to gracefully add a label or other attribute. I could see something like it being very useful in ngAria. https://github.com/angular/material/blob/master/src/services/aria/aria.js |
we could move it to ngAria, potentially |
I addressed this for now with btford@1e13d58 in my PR. It looks like the goal of this method is to provide a sensible default and also warn developers consuming the component that they may need to make a more informed decision. I like this, but it does add a few bytes to runtime. I think we may want to use a strategy similar to minerr but for warnings like this. |
$material
prefixes
@ThomasBurleson @ajoslin is there more work to do on this or can I close it with #340? |
Renamed as of 3368c93 |
With recent releases of Angular 1.3.x,
$aria
service conflicts withngAria
.ngAria
provides a$aria
service, which collides with the$aria
service inmaterial.services.aria
.Is there a reason material design services are
$
-prefixed?The text was updated successfully, but these errors were encountered: