This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(toast): Hide scrollbars during animation. #6017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During animation, certain browsers would show scroll bars if the toast was positioned at the bottom of the parent container. Fix by adding a class to the parent which sets the overflow to hidden only during the animations. Also, update documentation with notes about positioning and recommendations. Fixes #2936.
|
@jelbourn @robertmesserle @ThomasBurleson Please review when you have a moment and provide feedback on doc updates and any potential issues you see with this fix. |
|
@topherfangio I think a better solution would be to have a wrapper div that the toast animates within. So when it is below the fold, it will be hidden by that div and not trigger scrolling. |
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During animation, certain browsers would show scroll bars if the
toast was positioned at the bottom of the parent container.
Fix by adding a class to the parent which sets the overflow to
hidden only during the animations.
Also, update documentation with notes about positioning and
recommendations.
Fixes #2936.