Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(card): made md-card themeable #619

Closed
wants to merge 1 commit into from

Conversation

mzbyszynski
Copy link
Contributor

Hello There!

I'm really excited by what you have done so far with Angular Material Design. I've been working on building a POC for a 2015 project using angular and ngMaterial and I noticed that themes include css for md-card but md-card isn't themeable. This PR makes the md-card directive themable and adds two karma tests to confirm that it is themeable. Apologies in advance if I missed something or if md-card is intentionally not themeable, OR if I did not submit this issue/PR in the proper way.

Suggestions, feedback and schoolings in general always welcome as well!

Thank you,

-Marc

@vubui
Copy link

vubui commented Nov 12, 2014

Hey Marc, just curious: what is the POC thing that you were talking about? :D

@plato-cambrian
Copy link

i predict a set of material designed components for http://semantic-ui.com/

On Wed, Nov 12, 2014 at 9:06 AM, Vu Bui notifications@github.com wrote:

Hey Marc, just curious: what is the POC thing that you were talking about?
:D


Reply to this email directly or view it on GitHub
#619 (comment).

@mzbyszynski
Copy link
Contributor Author

Haha @plato-cambrian no nothing that ambitious! In my day job I'm putting together some POCs of a mobile-first redesign of a fairly large web application using angular, D3 and various ui frameworks. I have been working a lot with http://beta.semantic-ui.com/ but integrating semantic's js-based components within angular's apply loop is a challenge and mobile-first isn't necessarily their top design so when I found out about ngMaterial I thought I would give it a go.

Sorry for jibber-jabbering so much in my PR!

Please merge me :)

@ajoslin
Copy link
Contributor

ajoslin commented Nov 15, 2014

@mzbyszynski this looks great.

Once you sign the google CLA, I'll merge.

@ajoslin ajoslin self-assigned this Nov 15, 2014
@mzbyszynski
Copy link
Contributor Author

Thank you @ajoslin ! CLA signed.

@ajoslin ajoslin closed this in 55cdb5b Nov 16, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Nov 16, 2014

Merged! Thank you :-)

Great pull request with tests included. I would be very happy if you keep contributing!

robertmesserle pushed a commit that referenced this pull request Nov 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants