Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): set vertical alignment for md-button and md-raised-button #1565

Merged
merged 3 commits into from
Oct 26, 2016
Merged

fix(button): set vertical alignment for md-button and md-raised-button #1565

merged 3 commits into from
Oct 26, 2016

Conversation

tinayuangao
Copy link
Contributor

To make the md-icon correctly aligned

For issue #1454

R: @jelbourn

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 21, 2016
jelbourn
jelbourn reviewed Oct 25, 2016
View reviewed changes
src/lib/button/button.scss
@@ -47,6 +47,12 @@
}
}

[md-button], [md-raised-button] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment that explains what this style is for / why it was added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@fxck fxck mentioned this pull request Oct 25, 2016
Closed
tinayuangao
tinayuangao commented Oct 25, 2016
View reviewed changes
Copy link
Contributor Author

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment address. Thanks for review.

src/lib/button/button.scss
@@ -47,6 +47,12 @@
}
}

[md-button], [md-raised-button] {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 26, 2016
@jelbourn jelbourn merged commit f10ac7c into angular:master Oct 26, 2016
@tinayuangao tinayuangao deleted the button-alignment branch November 2, 2016 17:37
@PostImpatica
Copy link

Did anyone find that this actually aligned the icon? As far as I can tell it didn't fix the issue.

@PostImpatica
Copy link

Guess I'm not loading something correctly, what I have no idea. I manually added
[md-button], [md-raised-button] { .md-button-wrapper > * { vertical-align: middle; } }
to my main sass file to fix the issue.

@afriedma
Copy link

afriedma commented Jul 3, 2017

Can you guys please assist, do you know how to align text right below the icon?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tinayuangao @jelbourn @PostImpatica @afriedma @googlebot