feat(overlay): set overlay size #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
cla: yes
jelbourn
reviewed
Oct 24, 2016
| width: number; | ||
|
|
||
| /** The height of the overlay panel **/ | ||
| height: number; |
There was a problem hiding this comment.
We should support percent with this as well. I'd make the type number|string, assume numbers are px and strings are whole units.
| state.height = 500; | ||
|
|
||
| overlay.create(state).attach(componentPortal); | ||
| const pane = (<HTMLElement>overlayContainerElement.children[0]); |
There was a problem hiding this comment.
I want to start preferring the as cast syntax.
jelbourn
approved these changes
Oct 24, 2016
| @@ -58,6 +59,17 @@ export class OverlayRef implements PortalHost { | |||
| } | |||
| } | |||
|
|
|||
| /** Updates the size of the overlay based on the overlay config. */ | |||
| updateSize() { | |||
| if (this._state.width) { | |||
There was a problem hiding this comment.
It should probably work for zero as well.
| @@ -98,3 +110,7 @@ export class OverlayRef implements PortalHost { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| export function coerceToCSSFormat(value: number | string) { | |||
There was a problem hiding this comment.
formatCssUnit ?
Also it doesn't need to be exported just yet
|
@jelbourn Comments addressed! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two properties to the overlay state to manually configure the size of the overlay.
r: @jelbourn