fix: disable ripples when parent component is disabled #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
reviewed
Nov 9, 2016
| @@ -218,6 +218,17 @@ describe('MdRadio', () => { | |||
| expect(radioInstances.every(radio => !radio.checked)).toBe(true); | |||
| }); | |||
|
|
|||
| it('should not have a ripple on disabled radio buttons', () => { | |||
| let rippleElement = radioNativeElements[0].querySelector('[md-ripple'); | |||
There was a problem hiding this comment.
It looks like you're missing the end square bracket in the selector? Same on line 228.
jelbourn
force-pushed
the
ripple-disabled
branch
from
78cfe0d
to
28b3c0d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @tinayuangao or @kara
I noticed that disabled checkboxes and radio buttons still had active ripples on click. This fix needs to go in before we can do a release.