fix(button): improved tap responsiveness on mobile #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the tap responsiveness of buttons on mobile by replacing the `::after` overlay with a DOM node that prevents the default touch action. Previously, the `::after` overlay would capture the first tap, causing the button to have to tapped twice in order to fire it's click handler. Fixes angular#1316.
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 10, 2016
|
Renamed the overlay class and added a comment about the |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
Which version will this fix be in? |
|
@jelbourn can you put this in a 10-1 release soon? Currently, you'd have to monkey-patch the old workaround on every component to get it to work properly on IOS. |
|
Is this really out? |
|
It should be in |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the tap responsiveness of buttons on mobile by replacing the
::afteroverlay with a DOM node that prevents the default touch action.Previously, the
::afteroverlay would capture the first tap, causing the button to have to tapped twice in order to fire it's click handler.Fixes #1316.