feat(core): add scrollable view properties to connected pos strategy #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
andrewseguin
force-pushed
the
close-on-scroll-out
branch
5 times, most recently
from
7cfc35f
to
67e0684
Compare
jelbourn
reviewed
Dec 21, 2016
| } from './connected-position'; | ||
| import {Subject} from 'rxjs/Subject'; | ||
| import {Observable} from 'rxjs/Observable'; | ||
| import {Scrollable} from '../scroll/scrollable'; | ||
|
|
||
| export type ElementBoundingPositions = { |
There was a problem hiding this comment.
Add description for what this type is used for?
| let strategy = this._overlay.position().connectedTo(this._elementRef, origin, position); | ||
| strategy.withScrollableContainers(this._scrollDispatcher.getScrollContainers(this._elementRef)); | ||
| strategy.onPositionChange.subscribe((change: ConnectedOverlayPositionChange) => { |
There was a problem hiding this comment.
The type should be inferred here, so you should be able to just do
strategy.onPositionChange.subscribe(change => {
// ...
});
andrewseguin
force-pushed
the
close-on-scroll-out
branch
from
a8c0bbd
to
d670faa
Compare
andrewseguin
changed the title
andrewseguin
changed the title
|
Removed its usage in tooltip and sidenav until we optimize the number of scroll notifications with a throttle |
andrewseguin
changed the title
andrewseguin
force-pushed
the
close-on-scroll-out
branch
from
77bb07e
to
ac2f572
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses new Scrollable changes from #2188. Adds a set of properties to the change position event from the connected position strategy.
Still working on writing the tests for the connected position strategy but wanted to put this out for review to get it looked at ahead of time since beta is on Tuesday and we want this in there.