Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off view encapsulation for md-toolbar #676

Closed
kara opened this issue Jun 13, 2016 · 2 comments · Fixed by #678
Closed

Turn off view encapsulation for md-toolbar #676

kara opened this issue Jun 13, 2016 · 2 comments · Fixed by #678
Labels
help wanted The team would appreciate a PR from the community to address this issue

Comments

@kara
Copy link
Contributor

kara commented Jun 13, 2016

It's a bit difficult to style md-toolbar because ViewEncapsulation isn't turned off, as it is for other components. Chatted with @jelbourn about this, and we think it should be ViewEncapsulation.None.
@kara kara added the help wanted The team would appreciate a PR from the community to address this issue label Jun 13, 2016
@kara kara changed the title Turn off view encapsulation for toolbar Turn off view encapsulation for md-toolbar Jun 13, 2016
devversion added a commit to devversion/material2 that referenced this issue Jun 13, 2016
@devversion
fix(toolbar): disable view encapsulation.
fd71ae1 
* Disables the view encapsulation for the toolbar component.
  To be consistent with other components and simplify custom styling.

Fixes angular#676.
@devversion devversion mentioned this issue Jun 13, 2016
Merged
jelbourn pushed a commit that referenced this issue Jun 13, 2016
@devversion @jelbourn
fix(toolbar): disable view encapsulation. (#678)
5c4dc04 
* Disables the view encapsulation for the toolbar component.
  To be consistent with other components and simplify custom styling.

Fixes #676.
@kunalbariwal
Copy link

Hi. Elevation feature was added in "2.0.0-alpha.2 t-haircut" release (link here - 3e34f7a) but it was implemented only for button, card and sidenav components. What about rest of the components like toolbar etc. ? Or did I miss anything?

@yogeshgadge yogeshgadge mentioned this issue Jun 12, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted The team would appreciate a PR from the community to address this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(toolbar): disable view encapsulation. devversion/material2
2 participants
@kunalbariwal @kara