Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper subtitle styling possibility? #464

Open
da3dsoul1 opened this issue Jul 23, 2023 · 3 comments
Open

Proper subtitle styling possibility? #464

da3dsoul1 opened this issue Jul 23, 2023 · 3 comments
Labels
bug Something isn't working upstream issue

Comments

@da3dsoul1
Copy link

da3dsoul1 commented Jul 23, 2023

Amazing player, though lacks some basic functionality of properly displaying subtitles with embedded fonts in them.

Here's an example how subtitle look on both pc and mobile version of vlc/mpv player(sub-pos set to 87):
photo_2023-07-23_18-57-09
This is correct displaying meant by the author(font,size,style,etc)

And this is how next player displays them:
2
So as you can see it picks default font and styling for the subtitle, the player has an option to use embedded styles, but looks like it's not 100% compatible. Any way to fully utilize self contained subtitles in an .mkv file? Like it's done in vlc, mpv, mx player.

Also I have a feature request: subtitle position implementation, is it possible to be done in nextplayer?

@da3dsoul1 da3dsoul1 added the bug Something isn't working label Jul 23, 2023
@DarremMolko
Copy link

DarremMolko commented Jul 23, 2023

It's mentioned in the readme (here https://github.com/anilbeesetti/nextplayer#supported-formats). Basically Next Player is based on ExoPlayer which has limited support for SSA/ASS styling.

@anilbeesetti
Copy link
Owner

Unfortunately, this cannot be fixed easily due to the upstream ExoPlayer lacking proper support for SSA/ASS styling.
Upsteam issue link:- google/ExoPlayer#8435

@nate-moo
Copy link

nate-moo commented Feb 6, 2024

@anilbeesetti What would the possibility of implementing libass for SSA/ASS styling support since it seems like that exoplayer issue and PR have stalled or maybe rebasing exoplayer against this PR? google/ExoPlayer#10169
I can take a look at possibly doing it but I am not great at kotlin and android development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream issue
Projects
None yet
Development

No branches or pull requests

4 participants