-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It stoped working in latest Chrome and Firefox #928
Comments
I found the issue. reduced-motion, something that as a web-developer I never activated, if not set, get's picked up as set. If you remove this last part in animate.css:
Everything works again. Now, the questions that arises is:
For debuggin info, @daneden, I tested on Vanilla:
And vanilla:
And I confirm that it does not work, because of that media query. |
Hello. Unfortunately this is a bit confusing right now as it's not clear to everyone that this is an OS config. I might add this to the read me to clarify things. |
Yep. Because most people, like me, never touched that setting. And id
animations stop working, it might lead to crazyness 😉.
Maybe make those lines optional and not included by default?
Best,
|
Hello, For those who would like to reactivate this setting (before a hopfully new release of animate) :
Best Regards |
Good tip,
But that would just work for you. Other users might be in our situation,
therefore not having animations on their system when they actually want
them...
🙂
|
Hello, According to this google developer page https://developers.google.com/web/updates/2019/03/prefers-reduced-motion the media query has an additional parameter, either However, the media query which animate.css is using does not have a check for this parameter, and so I believe the rules are being applied regardless, even though I suspect in most instances it will be set to |
Just to make it clear, this is not a bug. It's the way the browser's implementation works. It's something that developers should be aware when using animate.css or any animation in a browser. Safari's implementation is based on the browser's configuration, not in a system wide implementation, for instance. @marlon-tucker, thanks for the reference. I'll have a look at the link and see if what's the best way to implement the feature. |
@eltonmesquita not a "bug" per se, but maybe not something that is forced, out of the box in an animation framework. Don't you agree? |
Hello everyone, I remember someone is requesting this feature to be an option for the developer who uses animate.css and makes it default to NO. I can't find that issue here so I refer here that issue. @eltonmesquita is it a good idea to make this feature an optional? and make it default as no? |
Wouldn't it be a better idea to use |
Thanks so much for this. I'm close to finishing a project and suddenly, all (or most) animations broke after a web-pack re-build. Took me a while to figure out what had caused the problem. Didn't expect animate.css to break since it's rather a simple framework. But very annoying. I'm having to use a custom version of the CSS file (with that part commented out). Can anyone please post a PROPER way to toggle this option. And I don't mean, just turn it off on my browser. |
Now I'm thinking that it wasn't because of the web-pack build. Because I checked and that section of the code was always there. It must be automatic chrome update. |
@marlon-tucker found the right reason. #932 |
This is a breaking issue, it causes the animation to stop working, elements to stop appearing and such. Can a fix for this be pushed ASAP? It's just a very minor change to the current rule. |
Solution committed, we are waiting for merge it to a release. You can check in pull requests... |
Temporary solution until new release published: |
@sivot Does not work either on Chrome 74 windows. |
@rendy44 what does not work? Show me your sample page or code. If animation not playing in linked codepen, then you need to enable animations in Windows. |
It's okay, if animations don't playing in only cases below:
In any other cases the animations need to playing...Change Reduce Motion Settings:
|
Just today I found out this thread. I spent the last 3 days trying to fix this in a very complex add. I made very simple test cases and found out that animate.css by itselft is causing this problem. The problem is that I use animate.css in hunderds of websites importing it from CDN. All those websites are broken right now. I think animate.css should make this Any idea if this stuff will be corrected and removed as default? |
Hello, I already recommend it and we are working on updates... here's my reply and suggestion about his issue.
@eltonmesquita is working on updates... |
Thanks! :) You said @eltonmesquita is "working"? The "work" is only to remove that |
@batata004 @eltonmesquita working on updates... which means not only that issue but all issues in this repo... also adding new features... that's why he is working on updates together with bug fixes ;) please be patient. |
Thanks this worked! |
A new version was release with the fix on #931. Now things should work better. |
See guys? I said earlier that @eltonmesquita is working on the new version with this fix... hehe |
Thanks so Much this solved my Issue. |
I had the problem (no animation) in google chrome some time ago, as animation in the windows settings were deactivated (and google - for whatever not to comprehend! reason - take care about . |
@FredyWenger sorry man but look like you don't understand this "reduce motion" concept. Helpful information for you: |
@sivot alright, thanks for the awesome reference! |
I'm on Windows 10, Chrome 79. I was experiencing no animation (after it had worked), while others in the office, who are also on Chrome 79 and Windows 10, would get animation. I typed Ease Of Access Display Settings in the menu. My "Show animations in Windows" was on but I turned it off and back on. That seemed to trip some other setting. Now it works. |
Folks, I'm using Win 7 and Chrome 80.x. I've always selected "Adjust for best performance" setting which unchecked all checkboxes on Visual Effects tab. I just tried to enable only "Fade or slide ToolTips in view" and it didn't work. I checked it here - https://codepen.io/badboy/full/eavwRg. I played with options and currently I have only one option enabled which is the very first one "Animate controls and elements inside windows" and I can confirm that animation (https://daneden.github.io/animate.css/ and https://codepen.io/badboy/full/eavwRg) works fine! |
I filed a bug with this one https://bugs.chromium.org/p/chromium/issues/detail?id=1197680 |
This is a bit confusing, but even your website, when you click "Animate" stopped working for latest chrome and firefox.
It does work in Edge, though. Any idea why?
I noticed it in a project, that all animations stopped working, and decided to theck your own website. Pretty weird this is test with chrome ( I am clicking the button).
The text was updated successfully, but these errors were encountered: