Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request update pyyaml submodule #176

Closed
septs opened this issue Jan 28, 2019 · 3 comments
Closed

Request update pyyaml submodule #176

septs opened this issue Jan 28, 2019 · 3 comments

Comments

@septs
Copy link

septs commented Jan 28, 2019

image

pyyaml library added .gitignore file

see https://github.com/yaml/pyyaml/blob/a27099bb68d5f045999d61f04476114292ce6ea5/.gitignore#L9-L10

@anishathalye
Copy link
Owner

I don't understand exactly what you are suggesting - could you clarify?

@septs
Copy link
Author

septs commented Jan 28, 2019

pyyaml introduced version before without .gitignore so it will generate .pyc file at runtime
Now pyyaml introduces .gitignore so you can hide these changes

I can see these files when using vscode maintenance.

@anishathalye
Copy link
Owner

The current PyYAML version that Dotbot uses seems to work fine, I don't think there's any reason to upgrade the dependency.

Plus, there seem to be issues with more recent releases, e.g. see the comments in hydrosquall/tiingo-python#124. The 4.1 release has been pulled (I think for bugs with Python 3.7 compatibility?), and there is no 4.2 release yet.

Also, you should be able to configure your editor to ignore pyc files (which should probably be ignored in a global gitignore anyways).

@septs septs closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants