Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing vis dependency to exact commit rather than master #17

Open
ozgenmuzac opened this issue Feb 3, 2020 · 0 comments
Open

Changing vis dependency to exact commit rather than master #17

ozgenmuzac opened this issue Feb 3, 2020 · 0 comments

Comments

@ozgenmuzac
Copy link

vis-react has a dependency to vis in package.json as seen here: https://github.com/anishmprasad/vis-react/blob/master/package.json#L13
When vis has a new commit on the master, the hash value of that dependency changes for that package and cause the failure of the dependency check. The idea is keeping the dependency package always the same for a given particular version of vis package. It would solve the problem if vis could point an exact version or commit hash as it was done for lodash and uuid as an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant