Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme.md: Update "build" to point to GitHub actions on master #8382

Closed
david-allison opened this issue Mar 29, 2021 · 5 comments · Fixed by #8386
Closed

Readme.md: Update "build" to point to GitHub actions on master #8382

david-allison opened this issue Mar 29, 2021 · 5 comments · Fixed by #8386
Labels
Good First Issue! Nondeveloper
Milestone
2.15 release

Comments

@david-allison
Copy link
Member

It currently points to TravisCI, which we no longer use

https://shields.io/ will provide a badge

Use build as the shield text
@Arnold2381
Copy link
Contributor

@david-allison-1 I was just out of curiosity looking for what badges are and what this issue actually wanted and after my research, I think we cant set a badge of actions using shield. I maybe wrong but I tried forming a link but couldn't because the parameters required do not match with Github link
image

And please if u can go through this issue, I think they have discussed the same problem
badges/shields#4559

@david-allison
Copy link
Member Author

"GitHub branch checks state" should work

@Arnold2381
Copy link
Contributor

@david-allison-1
https://img.shields.io/github/checks-status/ankidroid/Anki-Android/master?color=green&label=build
Does this work?

@david-allison
Copy link
Member Author

It does, but you need the provided URL from shields, not a permalink to a green check.

@david-allison
Copy link
Member Author

Sample: GitHub branch checks state

@Arnold2381 Arnold2381 mentioned this issue Mar 29, 2021
Merged
@mikehardy mikehardy added this to the 2.15 release milestone Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue! Nondeveloper
Projects
None yet
Milestone
2.15 release
Development

Successfully merging a pull request may close this issue.

Readme.md: Update "build" to point to GitHub actions on master #8382 Arnold2381/Anki-Android
3 participants
@mikehardy @Arnold2381 @david-allison