Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeckPicker: disable functionality during storage migration #13355

Merged
merged 5 commits into from
Feb 28, 2023
Merged

DeckPicker: disable functionality during storage migration #13355

merged 5 commits into from
Feb 28, 2023

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Feb 27, 2023 •
edited
Loading

Purpose / Description

A subset of functionality may be problematic while we are migrating storage.

Fixes

Approach

  • Show a snackbar when selected functionality is active
  • Do not disable 'restore from backup' functionality
  • ⚠️ DO not grey out the menu items
    • If they can be disabled with an explanation when clicked on, I'd support this - haven't looked into it

How Has This Been Tested?

Manually: API 31 AOSP emulator

Screenshot 2023-02-27 at 00 46 55
Screenshot 2023-02-27 at 00 46 42

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Review High Priority Request for high priority review Scoped storage labels Feb 27, 2023
mikehardy
mikehardy approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@mikehardy mikehardy added the Needs Second Approval Has one approval, one more approval to merge label Feb 27, 2023
@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Feb 28, 2023
@david-allison
Disable 'check database' if migrating storage
5361f8b 
Issue 5304
Issue 13094
@david-allison
Disable 'check media' if migrating storage
0512928 
This would incorrectly handle non-migrated media

Issue 5304
Issue 13094
@david-allison
Disable 'import' if migrating storage
59920ec 
Except for the 'restore from backup' error path

Issue 5304
Issue 13094
@david-allison
Disable 'export' if migrating storage
42725a1 
It's a possibility that the export would not have media migrated

Issue 5304
Issue 13094
@david-allison
Disable 'automatic sync' while migration is ongoing
31d7538 
Sync is blocked, but there's no point in showing a dialog - instead
don't perform the operation

Issue 5304
Issue 13094
@david-allison david-allison force-pushed the storage-migration-disable-deckpicker-functionality branch from b35be83 to cd9da5c Compare February 28, 2023 22:15
@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Feb 28, 2023
@david-allison
Copy link
Member Author

Changes made. Note: I (mildly) disagreed with #13355 (comment)

@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 28, 2023
@david-allison david-allison force-pushed the storage-migration-disable-deckpicker-functionality branch from cd9da5c to 31d7538 Compare February 28, 2023 22:17
@mikehardy mikehardy merged commit b7c7de1 into ankidroid:main Feb 28, 2023
@github-actions github-actions bot added this to the 2.16 release milestone Feb 28, 2023
@github-actions github-actions bot removed Review High Priority Request for high priority review Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) labels Feb 28, 2023
@david-allison david-allison deleted the storage-migration-disable-deckpicker-functionality branch February 28, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrayanDSO BrayanDSO BrayanDSO approved these changes

@mikehardy mikehardy mikehardy approved these changes

@lukstbit lukstbit Awaiting requested review from lukstbit

Assignees
No one assigned
Labels
Scoped storage
Projects
None yet
Milestone
2.16 release
Development

Successfully merging this pull request may close these issues.
3 participants
@david-allison @mikehardy @BrayanDSO