Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The BlockHash field on state is not meaningful and not used. #2546

Closed
Tracked by #2531
batconjurer opened this issue Feb 7, 2024 · 0 comments
Closed
Tracked by #2531

The BlockHash field on state is not meaningful and not used. #2546

batconjurer opened this issue Feb 7, 2024 · 0 comments
Assignees
@tzemanovic
Labels
bug Something isn't working pre-mainnet Must happen before mainnet.

Comments

@batconjurer
Copy link
Member

The field here

namada/crates/state/src/lib.rs

Line 124 in a7e581a

pub struct BlockStorage<H: StorageHasher> {

is actually always a hash of an empty vector. However, this field is not used meaningfully anywhere. It should probably just be removed.
@batconjurer batconjurer added the bug Something isn't working label Feb 7, 2024
@cwgoes cwgoes mentioned this issue Feb 7, 2024
Closed
13 tasks
@cwgoes cwgoes added the pre-mainnet Must happen before mainnet. label Feb 7, 2024
@cwgoes cwgoes mentioned this issue Feb 8, 2024
Closed
3 tasks
@batconjurer batconjurer mentioned this issue Mar 8, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzemanovic tzemanovic

Labels
bug Something isn't working pre-mainnet Must happen before mainnet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue 2546 anoma/namada
3 participants
@tzemanovic @batconjurer @cwgoes