You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we don't verify the allowlist before running vps (only when updating one in storage), but this could be a problem in case one of the vps was removed from the allowlist by a governance proposal (this is not guaranteed, it depends on which keys are removed and which are not). For extra safety I think we should validate every vp before running it anyway
The allowlist check for transactions is done in finalize_block. Once Bat/feat/remove tx queue #2627 is merged the execution of both the wrapper and the inner will happen in the same block meaning that this check will also prevent the execution of the wrapper and therefore fee payment. Moreover, this early check prevents replay protection from running some logic and decides whether to add the hash of the tx or not based on the section commitments. We should definitely address the former issue and try to solve the latter if possible too. In addition, after Bat/feat/remove tx queue #2627, we could also replicate the allowlist check in process_proposal and mempool too
The text was updated successfully, but these errors were encountered:
We decided to implement a soft version of vps removal from the allowlist: we'll remove the hash so that new accounts cannot be created with this vp but we'll keep the code so that the old accounts can still run it. This means that point 1 should not be implemented cause this would collide with the desired behavior
The followings are to be addressed:
finalize_block
. Once Bat/feat/remove tx queue #2627 is merged the execution of both the wrapper and the inner will happen in the same block meaning that this check will also prevent the execution of the wrapper and therefore fee payment. Moreover, this early check prevents replay protection from running some logic and decides whether to add the hash of the tx or not based on the section commitments. We should definitely address the former issue and try to solve the latter if possible too. In addition, after Bat/feat/remove tx queue #2627, we could also replicate the allowlist check inprocess_proposal
and mempool tooThe text was updated successfully, but these errors were encountered: