Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for negative inflation in PD controller #3231

Closed
sug0 opened this issue May 13, 2024 · 2 comments
Closed

Account for negative inflation in PD controller #3231

sug0 opened this issue May 13, 2024 · 2 comments
Labels
Milestone

Comments

@sug0
Copy link
Contributor

sug0 commented May 13, 2024

From the refactor in #2575:

// TODO: could possibly use I256 instead of Dec here (need to account for
// negative vals)
fn compute_inflation_aux(&self, control: Dec) -> Result<Uint, Error> {

@sug0 sug0 added the PoS label May 13, 2024
@sug0 sug0 added this to the To evaluate milestone May 13, 2024
@brentstone
Copy link
Collaborator

What do you mean by account for negative inflation in PD controller here? Dec can also contain negative values. I put the TODO here in case we wanted to do arithemtic just using integers rather than the Dec type, though I think perhaps we can remove the TODO. These numbers need to be signed since control may be negative.

@sug0 sug0 closed this as completed May 14, 2024
@sug0
Copy link
Contributor Author

sug0 commented May 14, 2024

removed in #3234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants