Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test MASP proof/sig verifications #3253

Closed
grarco opened this issue May 15, 2024 · 0 comments · Fixed by #3365
Closed

Test MASP proof/sig verifications #3253

grarco opened this issue May 15, 2024 · 0 comments · Fixed by #3365
Assignees
@tzemanovic
Labels
crypto MASP testing validity-predicate
Milestone
Phase 1: mainnet ...

Comments

@grarco
Copy link
Contributor

grarco commented May 15, 2024 •
edited
Loading

We should ensure to have at least one test that checks the correctness of the proofs/signatures verification in the masp vp. All the integration tests run with mocked builder/verifier so we cannot rely on them. The last masp e2e test will be removed in #3217. We still have the shielded action e2e tests but I believe it would be better to have a specific one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzemanovic tzemanovic

Labels
crypto MASP testing validity-predicate
Projects
None yet
Milestone
Phase 1: mainnet genesis
Development

Successfully merging a pull request may close this issue.

masp e2e test anoma/namada
3 participants
@tzemanovic @cwgoes @grarco