Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make access restrictions more flexible in web app access restrictions module #1176

Closed
mark4409 opened this issue Jun 1, 2023 · 2 comments · Fixed by #1558
Closed

Make access restrictions more flexible in web app access restrictions module #1176

mark4409 opened this issue Jun 1, 2023 · 2 comments · Fixed by #1558
Labels
has_pr PR fixes have been made medium_priority Medium priority question Further information is requested

Comments

@mark4409
Copy link

mark4409 commented Jun 1, 2023

SUMMARY

At the moment, the azure_rm_webappaccessrestriction only supports IP addresses (according to the latest documentation). There have been many times in the past where I have had to use service tags or vnets in these access restrictions so it would be great if this module would support those too

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

azure_rm_webappaccessrestriction

ADDITIONAL INFORMATION

This addition would prevent having to manually add configuration to the resource after deployment with ansible

- name: Configure web app access restrictions.
  azure.azcollection.azure_rm_webappaccessrestriction:
    name: "MyWebapp"
    resource_group: "MyResourceGroup"
    security_restrictions:
      - name: "Datacenter 1"
        action: "Allow"
        ip_address: "1.1.1.1/24"
        priority: 1
      - name: "Datacenter 2"
        action: "Allow"
        service_tag: "AzureCloud"
        priority: 2
      - name: "Datacenter 3"
        action: "Allow"
        subnet_id: "/subscriptions/xxx/resourceGroups/xxx/providers/Microsoft.Network/virtualNetworks/xxx/subnets/xxx"
        priority: 3
    scm_ip_security_restrictions_use_main: true
@Fred-sun
Copy link
Collaborator

Fred-sun commented Jun 8, 2023

@mark4409 The ‘scurity_restrictions' parameters include 'ip_security_restrictions' and 'scm_ip_security_restrictions', Do you mean we should add 'subnet_id' and 'tags' to the both parmaters? right?

@Fred-sun Fred-sun added question Further information is requested medium_priority Medium priority work in In trying to solve, or in working with contributors labels Jun 8, 2023
@Fred-sun Fred-sun added has_pr PR fixes have been made work in In trying to solve, or in working with contributors and removed work in In trying to solve, or in working with contributors has_pr PR fixes have been made labels Jun 16, 2023
@Fred-sun
Copy link
Collaborator

@mark4409 Added in #1558, Please take a try! Thank you very much!

@Fred-sun Fred-sun added has_pr PR fixes have been made and removed work in In trying to solve, or in working with contributors labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has_pr PR fixes have been made medium_priority Medium priority question Further information is requested
Projects
None yet
2 participants